Conversation
wow-miley
deleted the
email/pho-8-phosphor-introduce-platform-neutral-color-model-with-ansi
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a platform-neutral color stack in phosphor-core with NeutralColor, ColorRamp, PlatformColorAdapter, CognitiveColorModel, and an AnsiColorAdapter that supports ANSI256 and true-color output. Rewires existing ANSI-first paths (CognitiveColorRamp, Agent/Flow/Particle/Substrate/Terminal renderers) to source semantics through the new model while preserving current ANSI output, and deprecates direct ANSI constants with replacement guidance. Adds ComposeColorAdapter and updates ComposeRenderer to adapt ANSI indices through neutral colors so Compose consumers can use the same semantic palette source. Adds comprehensive tests for color parsing/interpolation, ANSI mapping fidelity, semantic model coverage, and Compose/ANSI consistency, and runs ./gradlew ktlintFormat and ./gradlew jvmTest.